Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host sample 23.a.hybrid-react-npm #2510

Closed
compulim opened this issue Oct 30, 2019 · 1 comment · Fixed by #2798
Closed

Host sample 23.a.hybrid-react-npm #2510

compulim opened this issue Oct 30, 2019 · 1 comment · Fixed by #2798
Assignees
@corinagum
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Oct 30, 2019 •
edited
Loading

Version

master

Describe the bug

Sample 23.a.hybrid-react-npm was added in PR #2509 but it lacked of hosting. We should host it.

That means, user reaching to https://microsoft.github.io/BotFramework-WebChat/samples/23.a.hybrid-react-npm will see the demo. We have hosted other create-react-app based samples. Look at lerna.json to get started.

Expected behavior

A hosted demo of the sample.

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Oct 30, 2019
@compulim compulim self-assigned this Oct 30, 2019
@corinagum corinagum added R7 and removed Pending labels Nov 4, 2019
@cwhitten cwhitten added R8 and removed R7 labels Nov 7, 2019
@tdurnford
Copy link
Contributor

Sample 17.b.clear-after-idle also needs to be hosted

@corinagum corinagum self-assigned this Dec 2, 2019
@compulim compulim added the QOL label Dec 17, 2019
corinagum added a commit to corinagum/BotFramework-WebChat that referenced this issue Jan 5, 2020
@corinagum
microsoft#2510 host hybrid-react and clear-after-idle samples
0c7fe27
@corinagum corinagum mentioned this issue Jan 5, 2020
Merged
corinagum added a commit that referenced this issue Jan 6, 2020
@corinagum
2794 & 2510 Fix change local, hybrid react, and clear after idle samp…
04fe2c3 
…les (#2798)

* #2794: Fix change-locale sample

* #2510 host hybrid-react and clear-after-idle samples

* Update CHANGELOG.md
@compulim compulim mentioned this issue Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
4 participants
@cwhitten @compulim @corinagum @tdurnford