Skip to content

Commit

Permalink
Add eslint-plugin-security and unify .eslintrc.yml (#4079)
Browse files Browse the repository at this point in the history
* Converge .eslintrc.yml

* Fix eslint-plugin-security

* Fix eslint-plugin-security

* Fix eslint-plugin-security

* Fix eslint-plugin-security

* Fix eslint-plugin-security

* Fix more ESLint issues

* Fix eslint-plugin-security

* Separate out .eslintrc.yml

* Unify usage of +index

* Fix defaultProps warning

* Use module.exports

* Fix slicedToArray helper not available

* Fix ESLint binary path

* Fix speech tests

* Fix test

* Fix Prettier

* Add entry

* Enable no-undefined and clean up

* Remove unnecessary .eslintignore

* Mark as CommonJS

* Fix no-sync

* Verbiage and various proofread fixes

* Fix test reliability
  • Loading branch information
compulim authored Nov 3, 2021
1 parent 53dfaa8 commit b6bc206
Show file tree
Hide file tree
Showing 239 changed files with 3,861 additions and 11,578 deletions.
43 changes: 43 additions & 0 deletions .eslintrc.node.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
plugins:
- node

extends:
- plugin:node/recommended

env:
node: true

parserOptions:
ecmaVersion: 2020

rules:
node/callback-return: error
node/global-require: error
node/handle-callback-err: error
node/no-missing-import:
- error
- tryExtensions:
- '.js'
- '.json'
- '.node'
- '.ts'
node/no-mixed-requires: error
node/no-new-require: error
node/no-path-concat: error
node/no-sync: error
node/no-unpublished-import: error
node/no-unpublished-require:
- error
# The following packages did not publish any exports.
- allowModules:
- express
- global-agent
- http-proxy-middleware
- istanbul-lib-coverage
- jest-environment-node
- jest-image-snapshot
- node-fetch
- p-defer-es5
- selenium-webdriver
- strip-ansi
node/prefer-global/buffer: error
104 changes: 104 additions & 0 deletions .eslintrc.react.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
plugins:
- react
- react-hooks

extends:
- plugin:react/recommended
- plugin:react-hooks/recommended

parserOptions:
ecmaFeatures:
jsx: true

settings:
react:
version: detect

rules:
react/button-has-type: error
react/default-props-match-prop-types: error
react/destructuring-assignment: error
react/display-name: off
react/forbid-component-props:
- error
- forbid:
- style
react/forbid-dom-props:
- error
- forbid:
- id
react/jsx-boolean-value:
- error
- always
react/jsx-closing-bracket-location:
- error
- tag-aligned
react/jsx-closing-tag-location: error
react/jsx-equals-spacing:
- error
- never
react/jsx-first-prop-new-line:
- error
- multiline-multiprop
react/jsx-handler-names: error
react/jsx-indent:
- error
- 2
react/jsx-indent-props:
- error
- 2
react/jsx-max-props-per-line:
- error
- maximum: 1
when: multiline
react/jsx-no-bind: error
react/jsx-no-literals: error
react/jsx-fragments:
- error
- element
react/jsx-pascal-case: error
react/jsx-props-no-multi-spaces: error
react/jsx-sort-default-props: error
react/jsx-sort-props: error
react/jsx-tag-spacing:
- error
- afterOpening: never
beforeClosing: never
beforeSelfClosing: always
closingSlash: never
react/jsx-wrap-multilines: error # Conflict with no-extra-parens
react/no-access-state-in-setstate: error
react/no-array-index-key: error
react/no-danger: error
react/no-did-mount-set-state: error
react/no-did-update-set-state: error
react/no-redundant-should-component-update: error
react/no-this-in-sfc: error
react/no-typos: error
react/no-unescaped-entities: error
react/no-unsafe: error
react/no-unused-prop-types: error
react/no-unused-state: error
react/no-will-update-set-state: error
react/prefer-es6-class: error
react/prefer-read-only-props: error
react/require-default-props: error
react/self-closing-comp: error
react/sort-prop-types: error
react/state-in-constructor: error
react/static-property-placement:
- error
- property assignment
react/style-prop-object: error
react/void-dom-elements-no-children: error

react-hooks/rules-of-hooks: error
react-hooks/exhaustive-deps: warn

# Conflicts with Adaptive Card schema.
# react/forbid-prop-types: error

# Rules we want to enable but conflicts with Prettier.
# react/jsx-one-expression-per-line:
# - error
# - allow: literal
Loading

0 comments on commit b6bc206

Please sign in to comment.