Add download attribute

microsoft · Feb 28, 2020 · 95d2792 · 95d2792
1 parent 3eb19da
commit 95d2792
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/__tests__/fileAttachment.js b/__tests__/fileAttachment.js
@@ -56,11 +56,21 @@ test('show ZIP files with contentUrl', async () => {
       document.querySelector('[role="listitem"]:nth-child(1) a[target="_blank"]').getAttribute('href')
     )
   ).resolves.toEqual('https://example.org/');
+  await expect(
+    driver.executeScript(() =>
+      document.querySelector('[role="listitem"]:nth-child(1) a[target="_blank"]').getAttribute('download')
+    )
+  ).resolves.toEqual('empty.zip');
   await expect(
     driver.executeScript(() =>
       document.querySelector('[role="listitem"]:nth-child(2) a[target="_blank"]').getAttribute('href')
     )
   ).resolves.toEqual('https://example.org/');
+  await expect(
+    driver.executeScript(() =>
+      document.querySelector('[role="listitem"]:nth-child(2) a[target="_blank"]').getAttribute('download')
+    )
+  ).resolves.toEqual('empty.zip');
 });
 
 test('show ZIP files without contentUrl', async () => {
@@ -111,4 +121,7 @@ test('show ZIP files without contentUrl', async () => {
   await expect(
     driver.executeScript(() => !!document.querySelector('[role="listitem"]:nth-child(2) a'))
   ).resolves.toBeFalsy();
+  await expect(
+    driver.executeScript(() => !!document.querySelector('[role="listitem"]:nth-child(1) a'))
+  ).resolves.toBeFalsy();
 });
diff --git a/packages/component/src/Attachment/FileContent.js b/packages/component/src/Attachment/FileContent.js
@@ -90,6 +90,7 @@ const FileContent = ({ className, href, fileName, size }) => {
         <a
           aria-hidden={true}
           className="webchat__fileContent__buttonLink"
+          download={fileName}
           href={href}
           rel="noopener noreferrer"
           target="_blank"