PR suggestion fixes

microsoft · Apr 29, 2019 · 834143f · 834143f
1 parent 04262a4
commit 834143f
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,7 +36,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fix [#1789](https://github.com/Microsoft/BotFramework-WebChat/issues/1789). Focus send box after message is being sent, by [@corinagum](https://github.com/corinagum) in PR [#1915](https://github.com/Microsoft/BotFramework-WebChat/pull/1915)
 - Fix [#1920](https://github.com/Microsoft/BotFramework-WebChat/issues/1920). Added disabled property to send button, by [@tdurnford](https://github.com/tdurnford) in PR [#1922](https://github.com/Microsoft/BotFramework-WebChat/pull/1922)
 - Fix [#1525](https://github.com/Microsoft/BotFramework-WebChat/issues/1525). Add JavaScript error Offline UI, by [@corinagum](https://github.com/corinagum) in PR [#1927](https://github.com/Microsoft/BotFramework-WebChat/pull/1927)
-- Fix [#1934](https://github.com/Microsoft/BotFramework-WebChat/issues/1934). Fix spacing of empty ConnectivityStatus component, by [@corinagum](https://github.com/corinagum) in PR [#XXX](https://github.com/Microsoft/BotFramework-WebChat/pull/XXX)
+- Fix [#1934](https://github.com/Microsoft/BotFramework-WebChat/issues/1934). Fix spacing of empty ConnectivityStatus component, by [@corinagum](https://github.com/corinagum) in PR [#1939](https://github.com/Microsoft/BotFramework-WebChat/pull/1939)
 
 ### Changed
 - Deployment: Bumps to [`[email protected]`](https://github.com/azure/blobxfer/), by [@compulim](https://github.com/compulim), in PR [#1897](https://github.com/Microsoft/BotFramework-WebChat/pull/1897)

diff --git a/packages/component/src/SendBox/ConnectivityStatus.js b/packages/component/src/SendBox/ConnectivityStatus.js
@@ -87,7 +87,7 @@ export default connectConnectivityStatus(
               { localize('RENDER_ERROR_NOTIFICATION', language) }
             </div>
           : connectivityStatus === 'reconnected' || connectivityStatus === 'connected' &&
-          <div className={ styleSet.connectivityNotificationEmpty } />
+            false
         }
       </DebouncedConnectivityStatus>
     </div>

diff --git a/packages/component/src/Styles/StyleSet/ConnectivityNotificationEmpty.js b/packages/component/src/Styles/StyleSet/ConnectivityNotificationEmpty.js
diff --git a/packages/component/src/Styles/createStyleSet.js b/packages/component/src/Styles/createStyleSet.js
@@ -10,7 +10,6 @@ import createBubbleStyle from './StyleSet/Bubble';
 import createCarouselFilmStrip from './StyleSet/CarouselFilmStrip';
 import createCarouselFlipper from './StyleSet/CarouselFlipper';
 import createConnectivityNotification from './StyleSet/ConnectivityNotification';
-import createConnectivityNotificationEmpty from './StyleSet/ConnectivityNotificationEmpty';
 import createDictationInterimsStyle from './StyleSet/DictationInterims';
 import createDownloadAttachmentStyle from './StyleSet/DownloadAttachment';
 import createErrorBoxStyle from './StyleSet/ErrorBox';
@@ -60,7 +59,6 @@ export default function createStyleSet(options) {
     carouselFilmStrip: createCarouselFilmStrip(options),
     carouselFlipper: createCarouselFlipper(options),
     connectivityNotification: createConnectivityNotification(options),
-    connectivityNotificationEmpty: createConnectivityNotificationEmpty(options),
     dictationInterims: createDictationInterimsStyle(options),
     downloadAttachment: createDownloadAttachmentStyle(options),
     errorBox: createErrorBoxStyle(options),