Skip to content

Commit

Permalink
#3265 Fix microphone button styling regression (#3276)
Browse files Browse the repository at this point in the history
* Fix microphone button styling regression

* Update CHANGELOG.md
  • Loading branch information
corinagum authored Jun 24, 2020
1 parent 1bb780c commit 0911f3d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

- Resolves [#3182](https://github.com/microsoft/BotFramework-WebChat/issues/3182). Added stacked suggested actions height properties, by [@corinagum](https://github.com/corinagum), in PR [#3235](https://github.com/microsoft/BotFramework-WebChat/pull/3235)

### Fixes

- Fixes [#3265](https://github.com/microsoft/BotFramework-WebChat/issues/3265). Fix styling specificity regression on microphone button, by [@corinagum](https://github.com/corinagum) in PR [#3276](https://github.com/microsoft/BotFramework-WebChat/pull/3276)

### Samples

- Resolves [#3218](https://github.com/microsoft/BotFramework-WebChat/issues/3218) and [#2811](https://github.com/microsoft/BotFramework-WebChat/issues/2811). Adds documentation on reconnecting to a conversation in minimizable sample, by [@corinagum](https://github.com/corinagum), in PR [#3239](https://github.com/microsoft/BotFramework-WebChat/pull/3239)
Expand Down
10 changes: 6 additions & 4 deletions packages/component/src/Styles/StyleSet/MicrophoneButton.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
export default function createMicrophoneButtonStyle({ microphoneButtonColorOnDictate }) {
return {
// TODO: [P3] This path should not know anything about the DOM tree of <IconButton>
'&.dictating > button': {
'&, &:focus, &:hover': {
'& svg': {
fill: microphoneButtonColorOnDictate
'&.dictating > .webchat__icon-button': {
'&:not(:disabled):not([aria-disabled="true"])': {
'&, &:focus, &:hover': {
'& svg': {
fill: microphoneButtonColorOnDictate
}
}
}
}
Expand Down

0 comments on commit 0911f3d

Please sign in to comment.