Fixed missing item in File menu on Win / Lin. #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath and
tdurnford
as code owners
srinaath
approved these changes
Mar 12, 2020
srinaath
added a commit
that referenced
this pull request
Mar 13, 2020
* Fixed missing item in File menu on Win / Lin. (#2100) * Fixed missing item in File menu on Win / Lin. * Fixed changelog entry PR # * Bump version to 4.8.0 (#2101) Signed-off-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Tony Anziano <[email protected]> Co-authored-by: Srinaath Ravichandran <[email protected]>
srinaath
pushed a commit
that referenced
this pull request
Mar 18, 2020
* Fixed missing item in File menu on Win / Lin. (#2100) * Fixed missing item in File menu on Win / Lin. * Fixed changelog entry PR # * Bump version to 4.8.0 (#2101) * Package updated Signed-off-by: Srinaath Ravichandran <[email protected]> * Added missing icon file for Linux / Mac (#2104) * Prevent passing props to activity middleware (#2105) * Prevent passing props to activity middleware * Package lock updated * Changelog updated * Corrected changelog * Added tests to ensure restart bubble not present (#2107) Should hide restart bubble if speech bot Co-authored-by: Srinaath Ravichandran <[email protected]> * Fixed a bug that was causing a blank User 'id' field. (#2108) * Fixed a bug that was causing a blank User 'id' field. * Added extra assertion in tests. * Ngrok Startup Options (#2111) * Make sure ngrok running loop not hit everytime * Ngrok reporting made accurate (#2113) * Recator isUsingNgrok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small bug in the File menu on Windows & Linux due to the addition of the Ngrok Debugger menu item. The PR #2032 that added that menu item added 2 new menu items, (the menu item itself and the separator), but the sign in and close tab menu items never had their indices adjusted to compensate for it.
So the "Close tab" menu item was being overwritten by the sign in item.
Before fix:
After fix: