fix: Fix dialog redirect/refresh behavior #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
requested changes
Aug 27, 2020
Composer/packages/client/src/recoilModel/dispatchers/__tests__/navigation.test.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/recoilModel/dispatchers/navigation.ts
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
approved these changes
Aug 27, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: Fix dialog redirect/refresh behavior * small changes * fix breadcrumb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
<DesignPage />component uses theuseEffecthook to select theOnBeginDialogtrigger when the user selects a dialog in the Project Tree. There are two issues with this approach. First, when the user refreshes the page or modifies the url, the page returns to theOnBeginDialogtrigger. Secondly, the page navigates to theAdaptiveDialogeditor first and then redirects toOnBeginDialogtrigger. This causes the screen to flash between the two editors instead of just rendering theOnBeginDialogtrigger.To resolve this, we shifted the responsibility to select the
OnBeginDialogtrigger from the<DesignPage />to thenavTodispatcher, which is called when the user selects a different dialog from the Project Tree. If the selected dialog has anOnBeginDialogtrigger, the dispatcher appends the selection to the url before navigating to the appropriate editor. This allows the user to freely refresh the browser and modify the url without navigating away from their intended editor. It also doesn't cause the design page to switch between theAdaptiveDialogand theOnBeginDialogeditors.Task Item
Closes #3770
Closes #3911