Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: azure deploy bugfix #3901

Merged
merged 5 commits into from
Aug 27, 2020
Merged

fix: azure deploy bugfix #3901

merged 5 commits into from
Aug 27, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Aug 26, 2020

Description

Bug: Test in Web Chat had no response
Fix: It should always create ${dialogName}.lu.qna.dialog in generated folder even there is an empty lu & qna file.

Task Item

fix #3897

Screenshots

@github-actions
Copy link

Coverage Status

Coverage remained the same at 56.315% when pulling 78c022f on julong/qna-deploy-bugfix into 78429de on main.

@alanlong9278
Copy link
Contributor Author

@zxyanliu Could u please help check it?

Composer/plugins/azurePublish/src/luisAndQnA.ts Outdated Show resolved Hide resolved
Composer/plugins/azurePublish/src/luisAndQnA.ts Outdated Show resolved Hide resolved
Composer/plugins/azurePublish/src/luisAndQnA.ts Outdated Show resolved Hide resolved
@zxyanliu
Copy link
Contributor

zxyanliu commented Aug 26, 2020

@alanlong9278

Fortunately, it worked on my side. Thanks for the fix! 👍

image

@boydc2014 boydc2014 merged commit f190785 into main Aug 27, 2020
@boydc2014 boydc2014 deleted the julong/qna-deploy-bugfix branch August 27, 2020 07:11
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* azure deploy bugfix

* code refactor

Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: VanyLaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provision new Azure resources and publish bot - Test in Web Chat had no response.
6 participants