Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use user's qna config in qna actions #3899

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Aug 26, 2020

Description

Use user's qna config in qna actions

Task Item

fix #3898 3898

Screenshots

image

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.003%) to 56.312% when pulling edc4eee on julong/qna-action-config into 78429de on main.

@boydc2014
Copy link
Contributor

@zxyanliu can you help check is this fixed your scenario?

@zxyanliu
Copy link
Contributor

zxyanliu commented Aug 26, 2020

@boydc2014 I did an end-to-end test today. Worked on my side.

  • Restarted bot and configuration looked good.

    image

  • Tested in Emulator with example question and got the expected answer.

    image

@zxyanliu
Copy link
Contributor

We might need to consider the potential impact of this fix on existing QnA implementation.

@cwhitten cwhitten merged commit 062bd41 into main Aug 27, 2020
@cwhitten cwhitten deleted the julong/qna-action-config branch August 27, 2020 00:42
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect to QnA KB issue
4 participants