Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Design tweaks to Skill Manifest Generation Wizard #3864

Merged
merged 2 commits into from
Aug 19, 2020
Merged

feat: Design tweaks to Skill Manifest Generation Wizard #3864

merged 2 commits into from
Aug 19, 2020

Conversation

tdurnford
Copy link
Collaborator

@tdurnford tdurnford commented Aug 19, 2020

Description

  • Endpoints Step
    • Hide the protocol property since it can only be set to 'BotFrameworkv3' at the moment
      • There was a bug in the Adaptive Form package that didn't set the default/const for hidden properties. To resolve this, we shifted the responsibility for hiding fields from the ObjectField to the SchemaField where the default/const values are set.
  • Dialog Selection Step
    • Added a description column with an editable field to change the dialog description
    • Added a 'Select all' checkbox and hid the select all checkbox in the table
  • Select Trigger Step
    • Added a 'Select all' checkbox and hid the select all checkbox in the table

Task Item

closes #3333

Screenshots

Endpoints Step

image

Select Dialogs

image

Select Triggers Step

image

@coveralls
Copy link

coveralls commented Aug 19, 2020

Coverage Status

Coverage decreased (-0.06%) to 56.967% when pulling 512a21b on tdurnford:feature/manifest-changes into f673648 on microsoft:main.

@@ -8,6 +8,10 @@ export function resolveRef(
definitions: { [key: string]: JSONSchema7Definition } = {}
): JSONSchema7 {
if (typeof schema?.$ref === 'string') {
if (!schema?.$ref?.startsWith('#/definitions/')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the refs in the Dialog Schema refer to 'http://json-schema.org/draft-07/schema#', so it throws the function throws an error since 'http://json-schema.org/draft-07/schema#' is not included in the definitions.

@cwhitten cwhitten merged commit 05e47eb into microsoft:main Aug 19, 2020
@tdurnford tdurnford deleted the feature/manifest-changes branch August 19, 2020 22:45
alanlong9278 added a commit that referenced this pull request Aug 20, 2020
* main:
  feat: enable js runtime (preview) (#3198)
  feat: Design tweaks to Skill Manifest Generation Wizard (#3864)
  feat: Update package to 4.10.0 and update schema and add samples for signoutuser  (#3862)
  fix lu inline update (#3861)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve skill manifest editing experience
3 participants