Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update circular reference list for schema parsing #3856

Merged
merged 1 commit into from
Aug 18, 2020
Merged

fix: update circular reference list for schema parsing #3856

merged 1 commit into from
Aug 18, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Adds schema to circular references to avoid stack overflow when parsing schema.

Task Item

#minor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.017% when pulling af0665a on lei9444:abrown/fix/parse-ask-schema into 1e09cb6 on microsoft:main.

@cwhitten cwhitten merged commit 9e70f32 into microsoft:main Aug 18, 2020
@lei9444 lei9444 deleted the abrown/fix/parse-ask-schema branch February 1, 2021 02:07
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@a-b-r-o-w-n
add schema to circular ref list (microsoft#3856)
29ae89e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinaath srinaath srinaath approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a-b-r-o-w-n @coveralls @srinaath @cwhitten