Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not strict new created dialog name to be lowercase #3817

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Aug 10, 2020

Description

  1. When create a dialog Hello now will create same case sensitive files:
dialogs/Hello/{Hello.dialog, Hello.lg, Hello.lu}

previous will created files:

dialogs/hello/{hello.dialog, hello.lg, hello.lu}
  1. Validation is case insensitive (addressed via fix: validate skill empty & add duplicate dialog #3686 )

Task Item

close #3814

Screenshots

@coveralls
Copy link

coveralls commented Aug 10, 2020

Coverage Status

Coverage remained the same at 56.422% when pulling b8394e2 on zhixzhan/dialog-naming-case into f1b8b4e on main.

@cwhitten cwhitten merged commit 0b3381d into main Aug 10, 2020
@cwhitten cwhitten deleted the zhixzhan/dialog-naming-case branch August 10, 2020 16:56
alanlong9278 added a commit that referenced this pull request Aug 11, 2020
* main:
  Update user.ts (#3825)
  do not force dialog name to lowercase (#3817)
  fix: lg editor validation error & intelligence (#3816)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog name should not force to be lower case
3 participants