feat: move composer plugin settings into ui schema #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generated from the sdk components
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
cwhitten
previously approved these changes
Jul 28, 2020
| rm -rf "./$BACKUP_SCHEMA_FILE" | ||
| rm -rf "./$BACKUP_UISCHEMA_FILE" | ||
| echo "Schema merged succesfully." |
There was a problem hiding this comment.
can we inform the user where this was written to?
a-b-r-o-w-n
requested review from
benbrown,
carlosscastro and
luhan2017
as code owners
cwhitten
approved these changes
Jul 29, 2020
cwhitten
approved these changes
Jul 29, 2020
srinaath
pushed a commit
that referenced
this pull request
Jul 29, 2020
* move composer plugin settings into ui schema generated from the sdk components * add uischema to runtime template * update schema scripts * add ui schema instructions to readme * update formatting * make script executable * echo what files were created * ignore backup files when merging
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* move composer plugin settings into ui schema generated from the sdk components * add uischema to runtime template * update schema scripts * add ui schema instructions to readme * update formatting * make script executable * echo what files were created * ignore backup files when merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use uischema generated from sdk components instead of the ui plugin.
Task Item
closes #3694