feat: support bot project's ui schema #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object.assign would replace previous values if values are undefined. Lodash skips those.
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
|
@a-b-r-o-w-n in the server, we check-in the sdk.schema and serve it to the client when we don't have one supplied with the open bot. Should we do something similar with the merged uischema? |
|
@cwhitten I'll update. For now, I'll just add an empty file which will eventually be replaced by the sdk ui schema. |
cwhitten
approved these changes
Jul 23, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* remove inspect port when starting server * wip - use map for project files data structure * complete refactor of files into a map * support app.uischema naming convention * move expression field into adaptive form package * update ui plugins to new ui schema * support new ui schema shape * load user overrides to ui schema * fix typos * update jest name * add some unit tests * update menu type * fix merging of flow config Object.assign would replace previous values if values are undefined. Lodash skips those. * add fallback uischema * load default ui schema if none found in bot project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for loading a bot project's ui schema as well as any user overrides. The schema has been defined here.
This also includes a refactor to support the new ui schema and adds some utilities to consume the merged result. Also introduces the composer ui plugin that houses the default ui schema. The ui schema will be migrated into the sdk shortly.
Task Item
Closes #3583