Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set deleteOldVersion to true when publishing luis #3661

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Jul 20, 2020

Description

delete old version when publishing luis.
The lubuild support this feature.
composer set deleteOldVersion to true.

Task Item

closes #3640

Screenshots

@coveralls
Copy link

coveralls commented Jul 20, 2020

Coverage Status

Coverage remained the same at 53.228% when pulling 9e7b4b3 on lei9444:luversiondelete into f2e9b4d on microsoft:main.

@boydc2014 boydc2014 added the Approved to merge approved, waiting to be merged label Jul 20, 2020
@boydc2014 boydc2014 merged commit 1b162af into microsoft:main Jul 21, 2020
alanlong9278 added a commit that referenced this pull request Jul 22, 2020
* main: (113 commits)
  doc: home page text (#3651)
  fix: set deleteOldVersion to true when publishing luis (#3661)
  import fix from PR#3666
  add error for nameless dialog file (#3666)
  clean the wrap
  update the app update
  wrap dispatcher to get latest state
  fix lint
  Removed awaits
  Added recoil to dev deps
  null check settings.luis
  More reduction in project payload size
  Reduced mock project response data
  update lgutils
  Update table-view.tsx
  update project test
  update publish luis test
  clean lg parser code and add tests for parser
  Renaming useResolver
  Export test complete
  ...
@hibrenda hibrenda mentioned this pull request Jul 23, 2020
7 tasks
@lei9444 lei9444 deleted the luversiondelete branch February 1, 2021 02:05
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
3 participants