fix: allow storage implementation to determine writability #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
cwhitten
approved these changes
Jul 22, 2020
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: fix: allow storage implementation to determine writability (microsoft#3630) fix: fix deploy issue because botproject files structure changed (microsoft#3719) fix: loop infinitely on publish page when get publish status (microsoft#3716)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…#3630) * Allow the Storage implementation to determine if a folder is writable or not * Remove legacy fs check on writability Co-authored-by: Chris Whitten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows the storage driver or plugin to determine whether or not a file or folder is writable. This is achieved by extending the
statinterface to include isWritable as a field, and to expect that field to be present when calculating this value for use in the client.This will allow third party storage plugins to determine who and where bot projects can be created using the appropriate internal mechanism. For example, using a logged in user identity to determine if a bot project is accessible.
Task Item
Fixes #3319
Screenshots
This controls where a bot project can be created. It appears in the "new bot" flow.