cleanup items for LU generation #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldplaying42
requested review from
boydc2014,
GeoffCoxMSFT and
a team
as code owners
chrimc62
reviewed
Jul 9, 2021
| @@ -155,7 +155,7 @@ | |||
|
|
|||
| # actionAssign(entity) | |||
| > Assign entity to current property | |||
| - ${list(where([actionSetOrPush(`@${entity}`), actionDeletePropertyToChange()], actions, actions != ''))} | |||
| - ${list(where([actionSetOrPush(`${entity}`), actionDeletePropertyToChange()], actions, actions != ''))} | |||
|
|
|||
There was a problem hiding this comment.
This tells me you have not tried to actually tested a generated dialog. I always build sandwich and interact with it to make sure scenarios work. Removing @ is only for labels in LU files. Here this is how you refer to an entity and it should be here. This whole file should not be changed.
There was a problem hiding this comment.
You mean the whole generator.lg should not be changed?
chrimc62
reviewed
Jul 9, 2021
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| # qnaAnswer_text() | |||
| > Show QnA answer | |||
| - ${@answer} | |||
| - ${answer} | |||
There was a problem hiding this comment.
This file should not be changed.
|
You should always test to see if things work. This does not work because @ is how you refer to entities at runtime. This change is only about removing the @ in the LU files--not in .dialog/trigger files. |
chrimc62
reviewed
Jul 9, 2021
| @@ -344,7 +344,7 @@ describe('dialog:generate --merge files', async function () { | |||
| await assertMissing('language-generation/en-us/BreadValue/sandwichMerge-BreadValue.en-us.lg', /white/, errors) | |||
| //sandwichMerge | |||
| await assertMissing('language-understanding/en-us/sandwichMerge.en-us.lu', /pulled/, errors) | |||
| await assertContains('language-understanding/en-us/Bread/sandwichMerge-Bread-BreadValue.en-us.lu', />- {@BreadProperty={@BreadValue=rye}}/, errors) | |||
| await assertContains('language-understanding/en-us/Bread/sandwichMerge-Bread-BreadValue.en-us.lu', />- {@BreadProperty={BreadValue=rye}}/, errors) | |||
chrimc62
reviewed
Jul 9, 2021
| - {@BreadProperty={@BreadValue=white} bread} | ||
| - {@BreadProperty={@BreadValue=whole} bread} | ||
| - {@BreadProperty={@BreadValue=whole wheat} bread} | ||
| - {@BreadProperty={BreadValue=multi}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3374
Proposed Changes
Testing