Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples][Java] Fix disparities of 81.skills-skilldialog sample #3279

Conversation

Batta32
Copy link
Contributor

@Batta32 Batta32 commented May 14, 2021

Related to microsoft/botbuilder-java#1165

Proposed Changes

We compared the documentation/code migration/behavior of the 81.skills-skilldialog sample between Java and C# and we found disparities and fixes that this PR includes.

  • Update READMEs
  • Clean-up autogenerated files/folder related to Eclipse (e.g. target/.classpath)
  • Add package-info.java files

Testing

Skills SkillDialog sample working as expected
image

@Batta32 Batta32 requested a review from a team as a code owner May 14, 2021 18:03
@tracyboehrer tracyboehrer merged commit c178b60 into microsoft:main May 17, 2021
@Batta32 Batta32 deleted the external/fix/southworks/java/samples/skills-skilldialog branch May 17, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants