Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples][Java] Fix disparities of 46.teams-auth sample #3264

Conversation

Batta32
Copy link
Contributor

@Batta32 Batta32 commented May 11, 2021

Related to microsoft/botbuilder-java#1165

Proposed Changes

We compared the documentation/code migration/behavior of the 46.teams-auth sample between Java and C# and we found disparities and fixes that this PR includes.

  • Update validation to logout in order to check if the text contains the string logout or not (like C#)
  • Remove join implementations
  • Update README
  • Add missing comments
  • Remove duplicated copyrights
  • Clean-up autogenerated files/folder related to Eclipse (e.g. target/.classpath)
  • Add package-info.java file

Testing

Teams Auth sample working as expected
image

@Batta32 Batta32 requested a review from a team as a code owner May 11, 2021 13:07
@tracyboehrer tracyboehrer merged commit 4065f6a into microsoft:main May 13, 2021
@Batta32 Batta32 deleted the external/fix/southworks/java/samples/teams-auth branch May 13, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants