Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples][Java] Fix disparities of 17.multilingual-bot sample #3232

Conversation

Batta32
Copy link
Contributor

@Batta32 Batta32 commented May 3, 2021

Related to microsoft/botbuilder-java#1165

Proposed Changes

We compared the documentation/code migration/behavior of the 17.multilingual-bot sample between Java and C# and we found disparities and fixes that this PR includes.

  • Update README
  • Clean-up autogenerated files/folder related to Eclipse (e.g. target/.classpath)
  • Add missing comments
  • Add package-info.java file

Testing

Multilingual Bot sample working as expected
PR

@Batta32 Batta32 requested a review from a team as a code owner May 3, 2021 19:02
@tracyboehrer tracyboehrer merged commit 217ea35 into microsoft:main May 5, 2021
@Batta32 Batta32 deleted the external/fix/southworks/java/samples/multilingual-bot branch May 5, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants