[Samples][Java] Fix disparities of 15.handling-attachments sample #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
approved these changes
May 5, 2021
Batta32
deleted the
external/fix/southworks/java/samples/handling-attachments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to microsoft/botbuilder-java#1165
Proposed Changes
We compared the documentation/code migration/behavior of the
15.handling-attachmentssample between Java and C# and we found disparities and fixes that this PR includes.asyncmethods tosyncin AttachmentsBottarget/.classpath)package-info.javafileTesting
Handling attachments sample working as expected
