Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples][Java] Fix disparities of 14.nlp-with-dispatch sample #3223

Conversation

Batta32
Copy link
Contributor

@Batta32 Batta32 commented Apr 30, 2021

Related to microsoft/botbuilder-java#1165

Proposed Changes

We compared the documentation/code migration/behavior of the 14.nlp-with-dispatch sample between Java and C# and we found disparities and fixes that this PR includes.

  • Add a validation in BotServicesImpl to check if the LUIS application is present in the application.properties
  • Update README
  • Move the files present in bots folder to the root one-
  • Clean-up autogenerated files/folder related to Eclipse (e.g. target/.classpath)
  • Add missing comments
  • Add missing Copyrights

Testing

NLP with dispatch sample working as expected
image

@Batta32 Batta32 requested a review from a team as a code owner April 30, 2021 17:14
@tracyboehrer tracyboehrer merged commit 7179ef6 into microsoft:main May 5, 2021
@Batta32 Batta32 deleted the external/fix/southworks/java/samples/nlp-with-dispatch branch May 5, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants