Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot Component Sample - JS #3252

Closed
2 tasks
clearab opened this issue May 6, 2021 · 5 comments
Closed
2 tasks

Bot Component Sample - JS #3252

clearab opened this issue May 6, 2021 · 5 comments
Assignees
Labels
P1 Painful if we don't fix, won't block releasing

Comments

@clearab
Copy link
Contributor

clearab commented May 6, 2021

We need to create samples for developers to get started creating components for Composer bots.

  • Samples should be full bot projects, with the component in a separate folder from the bot.
  • README should include instructions for opening the bot from Composer.
  • Base bot should be the empty bot template
  • Samples should have dialogs/actions that exercise the components

We need:

  • Custom action (based on existing multiply documentation)
  • Custom trigger (memberAdded & memberRemoved)
@clearab clearab added needs-triage The issue has just been created and it has not been reviewed by the team. feature-request A request for new functionality or an enhancement to an existing one. P0 Must Fix. Release-blocker and removed feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. labels May 6, 2021
@clearab clearab added this to the R13 milestone May 6, 2021
@joshgummersall
Copy link
Contributor

@clearab we don't yet have a great story for developing a component alongside a bot in JS short of some complex use of yarn link. Is this something that works well in .NET?

@clearab
Copy link
Contributor Author

clearab commented May 6, 2021

Yes - is this a solvable problem in JS?

@clearab clearab added P1 Painful if we don't fix, won't block releasing and removed P0 Must Fix. Release-blocker labels May 6, 2021
@alexstojda
Copy link

alexstojda commented Jun 7, 2021

Hi @clearab @joshgummersall, Do you have any expectation as to when this documentation & samples will be available?

I have been trying to setup the MultiplyDialog using the node runtime, but am running into some issues as described here: https://stackoverflow.com/questions/67876232/custom-action-for-composer-2-0-bot-not-executing

If I can get some assistance with that, it would give a complete example and resolve part of #3252

Thanks :)

@joshgummersall
Copy link
Contributor

@alexstojda, my best guess is something was wrong with your NPM installation or linking. I use yarn with workspaces to test these scenarios locally. I submitted a PR to your repo that sets this up. Give that a shot and see if works!

@alexstojda
Copy link

@joshgummersall thanks for the help! It worked perfectly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

4 participants