Ensure Entra tenant ID is formatted consistently in helper function #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-sam
approved these changes
Mar 4, 2024
…te/encimita/tenant-id-formatting
JesperSchulz
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Entra tenant ID returned from the System Application module is picked from a server setting, and is then immediately returned to the caller. There is no validation on its format.
For backwards compatibility, this will still be the case, but if the setting is a GUID (which should be the case in most supported cases), it will be formatted consistently. This makes our code using this function more robust.
Work Item(s)
Fixes AB#504179