-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#668 Actually return parameters #670
Merged
JesperSchulz
merged 3 commits into
microsoft:main
from
MODUSCarstenScholling:dev-668-missingattributes
Mar 1, 2024
Merged
#668 Actually return parameters #670
JesperSchulz
merged 3 commits into
microsoft:main
from
MODUSCarstenScholling:dev-668-missingattributes
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
github-actions
bot
added
AL: System Application
From Fork
Pull request is coming from a fork
labels
Feb 29, 2024
JesperSchulz
previously approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, nice implementation. What's not to like?
NKarolak
approved these changes
Mar 1, 2024
JesperSchulz
previously approved these changes
Mar 1, 2024
duichwer
approved these changes
Mar 1, 2024
grobyns
previously approved these changes
Mar 1, 2024
src/System Application/Test/Azure File Services API/src/AFSFileClientTest.Codeunit.al
Outdated
Show resolved
Hide resolved
MODUSCarstenScholling
dismissed stale reviews from grobyns and JesperSchulz
via
March 1, 2024 10:34
59f821d
Co-authored-by: Gert Robyns <[email protected]>
JesperSchulz
approved these changes
Mar 1, 2024
darjoo
approved these changes
Mar 1, 2024
JesperSchulz
pushed a commit
that referenced
this pull request
Mar 5, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary Actually return parameters to request to return attributes, timestamps, etag if requested. #### Work Item(s) Fixes #668 Fixes [AB#503067](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/503067) --------- Co-authored-by: Gert Robyns <[email protected]>
JesperSchulz
pushed a commit
that referenced
this pull request
Mar 5, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary Actually return parameters to request to return attributes, timestamps, etag if requested. #### Work Item(s) Fixes #668 Fixes [AB#503067](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/503067) --------- Co-authored-by: Gert Robyns <[email protected]>
JesperSchulz
added a commit
that referenced
this pull request
Mar 6, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Backport of #670 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#504264](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/504264) Co-authored-by: Carsten Scholling (MODUS Consult) <[email protected]> Co-authored-by: Gert Robyns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AL: System Application
From Fork
Pull request is coming from a fork
Integration
GitHub request for Integration area
Linked
Issue is linked to a Azure Boards work item
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Actually return parameters to request to return attributes, timestamps, etag if requested.
Work Item(s)
Fixes #668
Fixes AB#503067