Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#668 Actually return parameters #670

Merged
merged 3 commits into from
Mar 1, 2024
Merged

#668 Actually return parameters #670

merged 3 commits into from
Mar 1, 2024

Conversation

MODUSCarstenScholling
Copy link
Contributor

@MODUSCarstenScholling MODUSCarstenScholling commented Feb 29, 2024

Summary

Actually return parameters to request to return attributes, timestamps, etag if requested.

Work Item(s)

Fixes #668

Fixes AB#503067

@MODUSCarstenScholling MODUSCarstenScholling requested a review from a team as a code owner February 29, 2024 16:23
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Feb 29, 2024
JesperSchulz
JesperSchulz previously approved these changes Feb 29, 2024
Copy link
Contributor

@JesperSchulz JesperSchulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, nice implementation. What's not to like?

@JesperSchulz JesperSchulz added the Linked Issue is linked to a Azure Boards work item label Feb 29, 2024
@github-actions github-actions bot added this to the Version 25.0 milestone Feb 29, 2024
JesperSchulz
JesperSchulz previously approved these changes Mar 1, 2024
Co-authored-by: Gert Robyns <[email protected]>
@JesperSchulz JesperSchulz enabled auto-merge (squash) March 1, 2024 12:51
@JesperSchulz JesperSchulz merged commit cf5c6f8 into microsoft:main Mar 1, 2024
23 checks passed
JesperSchulz pushed a commit that referenced this pull request Mar 5, 2024
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary
Actually return parameters to request to return attributes, timestamps,
etag if requested.

#### Work Item(s)
Fixes #668 


Fixes
[AB#503067](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/503067)

---------

Co-authored-by: Gert Robyns <[email protected]>
JesperSchulz pushed a commit that referenced this pull request Mar 5, 2024
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary
Actually return parameters to request to return attributes, timestamps,
etag if requested.

#### Work Item(s)
Fixes #668 


Fixes
[AB#503067](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/503067)

---------

Co-authored-by: Gert Robyns <[email protected]>
JesperSchulz added a commit that referenced this pull request Mar 6, 2024
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Backport of #670 

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#504264](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/504264)

Co-authored-by: Carsten Scholling (MODUS Consult) <[email protected]>
Co-authored-by: Gert Robyns <[email protected]>
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Azure File Share ListDirectory not returning Attributes, Timestamps, ETag if requested
6 participants