Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.x] Fix issues with PowerBIManagement and OAuthIntegration #642

Merged
merged 2 commits into from
Feb 26, 2024
Merged

[24.x] Fix issues with PowerBIManagement and OAuthIntegration #642

merged 2 commits into from
Feb 26, 2024

Conversation

stkillen
Copy link
Contributor

@stkillen stkillen commented Feb 26, 2024 •
edited by github-actions bot
Loading

Summary

  1. Add missing reference to powerbi.js in PowerBIManagement
  2. Also reintroduce OAuthControlAddin as both should exist. OAuthIntegration is used to create an authorization link and needs a min height and width to do that. The OAuthControlAddin has no height and width.

Work Item(s)

Fixes AB#502394

@stkillen
[PowerBI] Add missing script reference to PowerBI Control Addin (#620)
7df9baa 
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
PowerBIManagement control add-in is missing a reference to powerbi.js.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#499250](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/499250/)
@stkillen
[OAuth] Reintroduce OAuthControlAddin for OnPrem support (#621)
5675c24 
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
OAuthControlAddin was obsoleted in previous PR in favor of
OAuthIntegration.

Both should exist, as OAuthIntegration is used to create an
authorization link and needs a min height and width to do that. The
OAuthControlAddin has no height and width.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#502131](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/502131/)
@stkillen stkillen requested a review from a team as a code owner February 26, 2024 15:05
@github-actions github-actions bot added this to the Version 24.1 milestone Feb 26, 2024
@stkillen stkillen enabled auto-merge (squash) February 26, 2024 15:17
@stkillen stkillen merged commit 3c5f15e into releases/24.x Feb 26, 2024
23 checks passed
@stkillen stkillen deleted the bugs/502396 branch February 26, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesperSchulz JesperSchulz JesperSchulz approved these changes

@darjoo darjoo darjoo approved these changes

Assignees
No one assigned
Labels
AL: System Application
Projects
None yet
Milestone
Version 24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@stkillen @darjoo @JesperSchulz