Add GetCollectionType to Edit-In Excel API #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darjoo
reviewed
Feb 12, 2024
src/System Application/App/Edit in Excel/src/Filters/EditInExcelFieldFilter.Interface.al
Outdated
Show resolved
Hide resolved
…ypeToEditInExcelAPI
|
Just putting this here, adding to the |
which just goes to show: compilation is not enough :-P |
encimita
reviewed
Apr 5, 2024
src/System Application/App/Edit in Excel/src/Filters/EditInExcelFilters.Codeunit.al
Show resolved
Hide resolved
src/System Application/App/Edit in Excel/src/Filters/EditInExcelFieldFilter.Interface.al
Outdated
Show resolved
Hide resolved
darjoo
reviewed
Apr 8, 2024
src/System Application/App/Edit in Excel/src/Filters/EditInExcelFieldFilter.Interface.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Edit in Excel/src/Filters/EditInExcelFldFilterImpl.Codeunit.al
Show resolved
Hide resolved
src/System Application/App/Edit in Excel/src/Filters/EditInExcelFilters.Codeunit.al
Show resolved
Hide resolved
encimita
previously approved these changes
Apr 8, 2024
darjoo
approved these changes
Apr 9, 2024
src/System Application/App/Edit in Excel/src/Filters/EditInExcelFilters.Codeunit.al
Show resolved
Hide resolved
src/System Application/App/Edit in Excel/src/Filters/EditInExcelFilters.Codeunit.al
Show resolved
Hide resolved
AndreasMoth
reviewed
Apr 9, 2024
src/System Application/App/Edit in Excel/src/Filters/EditInExcelFilters.Codeunit.al
Show resolved
Hide resolved
…ypeToEditInExcelAPI
JesperSchulz
approved these changes
Apr 18, 2024
DenLilleMand
deleted the
private/mattinielsen/AddGetFilterCollectionTypeToEditInExcelAPI
branch
JesperSchulz
pushed a commit
that referenced
this pull request
Apr 26, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> We merged in a PR updating the Edit-In Excel module API #550, but forgot about updating the documentation, namely the README.md which had examples using the old API. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#527688](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/527688/) Co-authored-by: Matti Nielsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue
We have received this issue: microsoft/ALAppExtensions#21940 where the programmer wants to move all of the filters from one field to another. The only thing missing for this capability is that we should be able to dynamically detect if the filter is a AND or OR expression, this is not possible in the current implementation.
Expected behavior
We should expose the "Edit in Excel Filter Collection Type" property on the filter through the API, such that clients of the API can dynamically detect what collection type the filter has.
Work Item(s)
Fixes AB#498510