[Copilot] Add authorization interface for managed resources #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgenijKorovin
previously approved these changes
Jun 4, 2024
darjoo
reviewed
Jun 4, 2024
src/System Application/App/AI/src/Azure OpenAI/AOAIResourceUtilization.Enum.al
Outdated
Show resolved
Hide resolved
src/System Application/App/AI/src/Azure OpenAI/AzureOpenAI.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/AI/src/Azure OpenAI/AOAIAuthorization.Codeunit.al
Show resolved
Hide resolved
src/System Application/App/AI/src/Azure OpenAI/AzureOpenAIImpl.Codeunit.al
Show resolved
Hide resolved
MonicaPAhuja
previously approved these changes
Jun 4, 2024
encimita
dismissed stale reviews from MonicaPAhuja and EvgenijKorovin
via
359af67
MonicaPAhuja
approved these changes
Jun 7, 2024
darjoo
approved these changes
Jun 7, 2024
encimita
added a commit
that referenced
this pull request
Jun 11, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Adds a new function to `AzureOpenAI.Codeunit.al` that allows partners approved for the private preview program to use the Microsoft managed AI resources. Reworked some of the logic in `AOAIAuthorization.Codeunit.al` to more clearly distinguish between the three authorization cases that we have today (first party, managed, self-managed), and created an enum to store that information. Polish logic to disallow background calls to Azure OpenAI. The previous logic wanted to express that calls in the background are allowed if it's the partner's own AOAI resource (the partner decides in that case), but not if it's using Microsoft managed resources. _Note: the logic at the moment does not verify that the partner AOAI deployment exists and is valid in the case of Managed resources. This is because we are currently in private preview, so the selected partners are already allowlisted. We will add the verification logic when we move to public preview._ #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#537361](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/537361) Fixes [AB#527684](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/527684)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new function to
AzureOpenAI.Codeunit.althat allows partners approved for the private preview program to use the Microsoft managed AI resources.Reworked some of the logic in
AOAIAuthorization.Codeunit.alto more clearly distinguish between the three authorization cases that we have today (first party, managed, self-managed), and created an enum to store that information.Polish logic to disallow background calls to Azure OpenAI. The previous logic wanted to express that calls in the background are allowed if it's the partner's own AOAI resource (the partner decides in that case), but not if it's using Microsoft managed resources.
Note: the logic at the moment does not verify that the partner AOAI deployment exists and is valid in the case of Managed resources. This is because we are currently in private preview, so the selected partners are already allowlisted. We will add the verification logic when we move to public preview.
Work Item(s)
Fixes AB#537361
Fixes AB#527684