Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

fix src/k4a_ros_device.cpp rclcpp::Duration(double) #275

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

soeroesg
Copy link

@soeroesg soeroesg commented Sep 13, 2023

Fixes

Fixes #270

fix src/k4a_ros_device.cpp rclcpp::Duration(double)

Description of the changes:

  • rclcpp::Duration(double) does not exist in ROS humble, instead we can use rclcpp::Duration::from_seconds())

Required before submitting a Pull Request:

  • I reviewed CONTRIBUTING.md
  • I built my changes locally
  • I tested my changes with a device
  • I changed both the ROS1 and ROS2 branches (the change only applies to ROS2)

I tested changes on:

  • Windows (I have no ROS on Windows but the change is minimal)
  • Linux
  • ROS1 (no change needed)
  • ROS2

rclcpp::Duration(double) does not exist in ROS humble
@Thaina
Copy link

Thaina commented Mar 29, 2024

Same here on kinect k4a sample for unity. Can it be used the same fix?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants