Add workflow default to RP_BUNDLE_VALUES #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalyaron
approved these changes
Apr 16, 2023
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4713636628 (with refid (in response to this comment from @tamirkamara) |
tamirkamara
force-pushed
the
tamirkamara/fix-rp-bundle-var-default
branch
from
75c083a
to
129a88a
Compare
tamirkamara
force-pushed
the
tamirkamara/fix-rp-bundle-var-default
branch
from
129a88a
to
4ec1323
Compare
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4717772768 (with refid (in response to this comment from @tamirkamara) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4718285841 (with refid (in response to this comment from @tamirkamara) |
damoodamoo
approved these changes
Apr 17, 2023
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4718954057 (with refid (in response to this comment from @tamirkamara) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being addressed
RP_BUNDLE_VALUESis an optional variable but its workflow default is an empty string (as is for any secret/var we use in the reusable workflow). That is invalid value in Terraform as the variable is defined as a map.How is this addressed
{}as the workflow default for the param.