Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip certs e2e on Fri/Sat #3203

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

tamirkamara
Copy link
Collaborator

Resolves #3202

What is being addressed

Certs provisioning in E2E will fail the nightly run twice a week due to letsencrypt limits.

How is this addressed

  • Skip the test of Friday and Saturday

@tamirkamara
Copy link
Collaborator Author

/test-shared-services

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

🤖 pr-bot 🤖

🏃 Running shared service tests: https://github.com/microsoft/AzureTRE/actions/runs/4111677974 (with refid 433cde8c)

(in response to this comment from @tamirkamara)

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit abaf8e1.

♻️ This comment has been updated with latest results.

Copy link
Member

@martinpeck martinpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment about a typo.

CHANGELOG.md Outdated Show resolved Hide resolved
@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@tamirkamara tamirkamara enabled auto-merge (squash) February 7, 2023 09:54
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit abaf8e1)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 36a16c4 into main Feb 7, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3202-disable-certs-e2e-on-weekends branch February 7, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certs E2E fails due to letsencrypt limits per week
2 participants