Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Databricks private authentication shared service for SSO #3201

Merged
merged 9 commits into from
Feb 26, 2023
Merged

Add Databricks private authentication shared service for SSO #3201

merged 9 commits into from
Feb 26, 2023

Conversation

guybartal
Copy link
Contributor

@guybartal guybartal commented Feb 6, 2023 •
edited
Loading

Resolves #3182

What is being addressed

Databricks SSO mechanism designed to work with a single Azure Databricks Auth sub resource deployed once per region and private DNS zone. This PR along with #3199 addresses that.

How is this addressed

  • Add a shared service to deploy a private authentication Databricks workspace with private link to Databricks DNS zone inside core.

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 1b45011.

♻️ This comment has been updated with latest results.

@guybartal
Copy link
Contributor Author

/test

@guybartal guybartal enabled auto-merge (squash) February 6, 2023 22:04
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4108325191 (with refid 0413ddbe)

(in response to this comment from @guybartal)

@tamirkamara tamirkamara marked this pull request as draft February 7, 2023 10:41
auto-merge was automatically disabled February 7, 2023 10:41

Pull request was converted to draft

@guybartal
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4155622865 (with refid 0413ddbe)

(in response to this comment from @guybartal)

@marrobi
Copy link
Member

marrobi commented Feb 22, 2023

Verified can access a DB workspace provisioned in a VNet outside of the TRE with a private endpoint in the shared services area:

image

@guybartal guybartal marked this pull request as ready for review February 22, 2023 16:38
@guybartal
Copy link
Contributor Author

Thanks for testing that @marrobi!
I'll go ahead and merge it.

@guybartal
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4244913184 (with refid 0413ddbe)

(in response to this comment from @guybartal)

marrobi
marrobi approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. @guybartal and @promisinganuj .

@guybartal
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4274034095 (with refid 0413ddbe)

(in response to this comment from @guybartal)

@guybartal guybartal enabled auto-merge (squash) February 26, 2023 08:44
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:54 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 10:55 — with GitHub Actions Inactive
@guybartal guybartal temporarily deployed to CICD February 26, 2023 11:18 — with GitHub Actions Inactive
@github-actions
Copy link

E2E Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 1b45011. ± Comparison against base commit ed9c3d5.

@guybartal
Copy link
Contributor Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 1b45011)

(in response to this comment from @guybartal)

@guybartal guybartal merged commit 2b356a6 into microsoft:main Feb 26, 2023
@guybartal guybartal deleted the guybartal/databricks-auth-shared-service branch February 26, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrobi marrobi marrobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot login to Databricks - auth endpoint cannot be reached.
2 participants
@guybartal @marrobi