Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up review VMs for cancelled Airlock requests #3130

Merged
merged 16 commits into from
Jan 30, 2023
Merged

Clean up review VMs for cancelled Airlock requests #3130

merged 16 commits into from
Jan 30, 2023

Conversation

yuvalyaron
Copy link
Collaborator

@yuvalyaron yuvalyaron commented Jan 26, 2023 •
edited
Loading

Resolves #2829

What is being addressed

Review VMs are being cleaned up when an Airlock request is canceled.

How is this addressed

  • Moved the logic of cancelling airlock requests from the route to the service and added a call to delete review VMS
  • Added "disable VM" call to the method that deletes the review VM - this is necessary as disabling the resource might carry important logic, and this is what we force users to do in the UI (you can't delete a resource without disabling first).

@yuvalyaron yuvalyaron marked this pull request as ready for review January 26, 2023 16:02
@github-actions
Copy link

github-actions bot commented Jan 26, 2023 •
edited
Loading

Unit Test Results

554 tests   554 ✔️  13s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit c48443b.

♻️ This comment has been updated with latest results.

tamirkamara
tamirkamara reviewed Jan 29, 2023
View reviewed changes
api_app/_version.py Outdated Show resolved Hide resolved
anatbal
anatbal approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@anatbal anatbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvalyaron
Copy link
Collaborator Author

/test

@yuvalyaron yuvalyaron enabled auto-merge (squash) January 30, 2023 12:52
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4044009151 (with refid 664fed0d)

(in response to this comment from @yuvalyaron)

@yuvalyaron
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4044958579 (with refid 664fed0d)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit 7f59c6c into microsoft:main Jan 30, 2023
@yuvalyaron yuvalyaron deleted the 2829-delete-review-vms-on-cancel branch January 30, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara left review comments

@anatbal anatbal anatbal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up any review VMs if the request is cancelled
3 participants
@yuvalyaron @anatbal @tamirkamara