Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Guacamole dependencies #3053

Merged
merged 5 commits into from
Jan 4, 2023
Merged

Upgrade Guacamole dependencies #3053

merged 5 commits into from
Jan 4, 2023

Conversation

tamirkamara
Copy link
Collaborator

Resolves #2914

What is being addressed

Out of date dependencies used in the Guacamole bundle/extension

How is this addressed

  • Upgrade versions

@github-actions
Copy link

github-actions bot commented Jan 4, 2023 •
edited
Loading

Unit Test Results

15 tests   15 ✔️  2s ⏱️
  4 suites    0 💤
  4 files      0 ❌

Results for commit 3632287.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@tamirkamara tamirkamara marked this pull request as ready for review January 4, 2023 08:43
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3836462454 (with refid c60dd94a)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3836462454 (with refid c60dd94a)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3836850788 (with refid c60dd94a)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3838042638 (with refid c60dd94a)

(in response to this comment from @tamirkamara)

eladiw
eladiw approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@eladiw eladiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tamirkamara
Copy link
Collaborator Author

/test-extended

@tamirkamara tamirkamara enabled auto-merge (squash) January 4, 2023 14:50
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3839026613 (with refid c60dd94a)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 8d87baf into main Jan 4, 2023
@tamirkamara tamirkamara deleted the tamirkamara/2914-guacamole-deps-upgrade branch January 4, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladiw eladiw eladiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade guacamole-auth-azure dependencies
2 participants
@tamirkamara @eladiw