-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airlock UI: support multiple review vms #2883
Airlock UI: support multiple review vms #2883
Conversation
(apart from rsjf as next is in beta)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API part looks great!
Left some small nits / comments but up to you whether to apply them
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3575859656 (with refid (in response to this comment from @jjgriff93) |
https://github.com/microsoft/AzureTRE into jjgriff93/2764-airlock_ui-support_multiple_review_vms
/test-force-approve (no e2e changes wince test pass: https://github.com/microsoft/AzureTRE/actions/runs/3575859656) |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit d37da69) (in response to this comment from @jjgriff93) |
Resolves #2764
What is being addressed
This PR adds support in the API and UI for multiple reviewers being able to create review VMs for an airlock request. This also adds functionality for re-deploying a review resource if it's in a failed state and automatic clean-up of the previous resource.
How is this addressed