Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock UI: support multiple review vms #2883

Merged
merged 27 commits into from
Nov 29, 2022

Conversation

jjgriff93
Copy link
Collaborator

@jjgriff93 jjgriff93 commented Nov 15, 2022

Resolves #2764

What is being addressed

This PR adds support in the API and UI for multiple reviewers being able to create review VMs for an airlock request. This also adds functionality for re-deploying a review resource if it's in a failed state and automatic clean-up of the previous resource.

image

How is this addressed

  • Changed reviewUserResources from array to dictionary, using the signed-in user's userId as the key to ensure one user resource per user
  • Added migration to update from previous format
  • Expanded /create-review-resource API to do a check for an existing resource, in which case it checks its health, returns a 409 conflict if healthy, otherwise redeploys and removes the old failed resource
  • Also made some general improvements to the airlock experience - allowed actions are now returned with most airlock API calls meaning the user doesn't need to refresh the UI for some options to appear when a request is updated
  • Review user resource block shows loading shimmers/spinner instead of defaulting to not created view when looking up an existing resource
  • Updated to React 18 and updated dependencies to latest versions
  • Update CHANGELOG.md

@jjgriff93 jjgriff93 enabled auto-merge (squash) November 15, 2022 23:27
@github-actions
Copy link

github-actions bot commented Nov 15, 2022

Unit Test Results

522 tests   521 ✔️  19s ⏱️
    1 suites      0 💤
    1 files        1

For more details on these failures, see this check.

Results for commit d37da69.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@tanya-borisova tanya-borisova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API part looks great!
Left some small nits / comments but up to you whether to apply them

api_app/api/routes/airlock.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
api_app/api/routes/airlock_resource_helpers.py Outdated Show resolved Hide resolved
@jjgriff93
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3575859656 (with refid edf02077)

(in response to this comment from @jjgriff93)

@jjgriff93
Copy link
Collaborator Author

/test-force-approve (no e2e changes wince test pass: https://github.com/microsoft/AzureTRE/actions/runs/3575859656)

@jjgriff93 jjgriff93 enabled auto-merge (squash) November 29, 2022 18:24
@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit d37da69)

(in response to this comment from @jjgriff93)

@microsoft microsoft deleted a comment from github-actions bot Nov 29, 2022
@jjgriff93 jjgriff93 merged commit db1d6dd into main Nov 29, 2022
@jjgriff93 jjgriff93 deleted the jjgriff93/2764-airlock_ui-support_multiple_review_vms branch November 29, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple review resources in Airlock Review VM UI
2 participants