Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display UI version in the footer #2849

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Display UI version in the footer #2849

merged 2 commits into from
Nov 9, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Nov 9, 2022

Resolves #2661

What is being addressed

  1. Display the ui version in the footer info card
  2. CI checks that the version has been updated when the ui folder changes

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit faf3d57.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review November 9, 2022 11:13
@tamirkamara tamirkamara enabled auto-merge (squash) November 9, 2022 11:15
@damoodamoo
Copy link
Member

love this! might be worth getting #2846 through first, just in case there's a clash in the footer code, but this is cool.

@tamirkamara
Copy link
Collaborator Author

/test-force-approve

love this! might be worth getting #2846 through first, just in case there's a clash in the footer code, but this is cool.

Yes, I'm waiting for it.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit faf3d57)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 5a22504 into main Nov 9, 2022
@tamirkamara tamirkamara deleted the tamirkamara/ui-version branch November 9, 2022 12:13
@tamirkamara
Copy link
Collaborator Author

tamirkamara commented Nov 9, 2022

oh no.
I had already the test command from a few hours ago I didn't submit and that went in together with me agreeing to wait for #2846. Sorry @jjgriff93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add health information to footer
2 participants