Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Resource Processor logging and disk size #2486

Merged
merged 3 commits into from
Aug 21, 2022
Merged

Update Resource Processor logging and disk size #2486

merged 3 commits into from
Aug 21, 2022

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

  1. Resource processor log warnings when the bundle's image isn't present locally.
  2. Its disk is too small and images are cached for too long

How is this addressed

  • If porter output only contains the message about the image missing locally, then set the log to info (rather than warning)
  • Double the disk size and docker prune when usage is above 70%

@github-actions
Copy link

github-actions bot commented Aug 21, 2022 •
edited
Loading

Unit Test Results

0 tests   - 5   0 ✔️  - 3   0s ⏱️ - 2h 15m 30s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0 ❌  - 2 

Results for commit fba3d56. ± Comparison against base commit f6d0ac2.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2897289573 (with refid 85acc730)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) August 21, 2022 07:15
anatbal
anatbal approved these changes Aug 21, 2022
View reviewed changes
Copy link
Contributor

@anatbal anatbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara tamirkamara merged commit 9ea7664 into main Aug 21, 2022
@tamirkamara tamirkamara deleted the tamirkamara/update-rp-and-logging branch August 21, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatbal anatbal anatbal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamirkamara @anatbal