Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guacamole sends logs to app insights #2376

Merged
merged 4 commits into from
Jul 31, 2022

Conversation

tamirkamara
Copy link
Collaborator

Resolves #1938

What is being addressed

Guacamole logs weren't being sent to app insights since we didn't have one in the workspace level, which we do now...

How is this addressed

  • Include app insights in the guacamole image so that logs will be forwarded
  • Move the version file for its docker image into the image directory instead of the root one
  • Upgrade Java and Tomcat versions

@tamirkamara tamirkamara requested a review from anatbal July 31, 2022 08:25
@github-actions
Copy link

github-actions bot commented Jul 31, 2022

Unit Test Results

15 tests   15 ✔️  2s ⏱️
  4 suites    0 💤
  4 files      0

Results for commit 596f505.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@anatbal anatbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comment

@tamirkamara tamirkamara marked this pull request as ready for review July 31, 2022 11:02
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2769229971 (with refid abff6401)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2769523750 (with refid abff6401)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 9c44faf into main Jul 31, 2022
@tamirkamara tamirkamara deleted the tamirkamara/1938-guacamole-logs-in-appinsights branch July 31, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include AppInsights with Guacamole
2 participants