Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide address space to Workspace Service #1846

Closed
5 tasks done
marrobi opened this issue May 16, 2022 · 1 comment
Closed
5 tasks done

Provide address space to Workspace Service #1846

marrobi opened this issue May 16, 2022 · 1 comment
Assignees
@marrobi
Labels
api Composition Service API blocked Cannot progress at present feature python Pull requests that update Python code

Comments

@marrobi
Copy link
Member

marrobi commented May 16, 2022 •
edited
Loading

Description

As a TRE Service Integrator
I want to get the next available address space when deploying a workspace service
So that I can create a new address space that does not overlap with any existing address spaces and add it to the workspace

  • required for AML as needs service endpoints and specific NSG rules on the compute subnet
  • required for databricks as needs subnets with specific configuration
  • required were a new subnet needs to be created for delegation, for example for ACI

Acceptance criteria

  • Can deploy a workspace service with parameter address_space and get a free address space
  • Can add address space to workspace from a workspace service installation

Implementation

Currently, /api_app/services/cidr_service.py is called from the repositories/workspaces.py to find the next available address-space when creating a workspace. This could help when a request is served by workspace_services.py
@marrobi marrobi added the story Stories are the smallest unit of work to be done for a project. label May 16, 2022
@marrobi marrobi self-assigned this May 16, 2022
@marrobi marrobi changed the title Workspace Service needs address space for additional Vnet Workspace Service needs address space to deploy to May 18, 2022
@ross-p-smith ross-p-smith added size/S api Composition Service API python Pull requests that update Python code labels Jun 1, 2022
@marrobi marrobi added this to the Release 0.4 milestone Jun 9, 2022
@marrobi marrobi mentioned this issue Aug 17, 2022
Closed
This was referenced Oct 31, 2022
Closed
Merged
@marrobi marrobi changed the title Workspace Service needs address space to deploy to Provide address space to Workspace Service Oct 31, 2022
@marrobi marrobi added feature and removed size/S labels Oct 31, 2022
@marrobi marrobi removed the story Stories are the smallest unit of work to be done for a project. label Oct 31, 2022
@marrobi marrobi mentioned this issue Nov 2, 2022
Merged
2 tasks
@marrobi marrobi moved this from Next to In Progress in AzureTRE Feature Roadmap Nov 4, 2022
@marrobi
Copy link
Member Author

marrobi commented Nov 9, 2022

Blocked by #2847

marrobi added a commit to marrobi/AzureTRE that referenced this issue Nov 22, 2022
@marrobi
++Provide address space to Workspace Service
6b127a4 
Fixes microsoft#1846
@marrobi marrobi mentioned this issue Jan 4, 2023
Merged
3 tasks
@marrobi marrobi moved this from In Progress to Initial Scope Complete in AzureTRE Feature Roadmap Feb 6, 2023
@marrobi marrobi closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marrobi marrobi

Labels
api Composition Service API blocked Cannot progress at present feature python Pull requests that update Python code
Projects
AzureTRE Feature Roadmap
Status: Initial Scope Complete
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ross-p-smith @marrobi