Skip to content
This repository has been archived by the owner on Oct 31, 2019. It is now read-only.

Fix errors in vignettes #75

Closed
Alanwe opened this issue Jun 12, 2017 · 3 comments
Closed

Fix errors in vignettes #75

Alanwe opened this issue Jun 12, 2017 · 3 comments
Assignees
Milestone

Comments

@Alanwe
Copy link
Member

Alanwe commented Jun 12, 2017

Authentication vignette:

  • Change in portal names.
  • Users -> Access Control (IAM) (15/17)

Walkthrough

  • Some UpperCamelCase functions
  • Some Az naming issues

Blob Storage Authentication - Could be clearer, Authentication without AD example

@Alanwe Alanwe self-assigned this Jun 12, 2017
@andrie
Copy link
Contributor

andrie commented Jun 12, 2017

Thanks for flagging and assigning yourself.

While you're at it, can you please try to write the examples in such a way the functions will run without errors in Azure?

For example, illustrate the end-to-end flow of creating a resource, doing something with it, and then deleting the resource.

In this way, we can run the tests automatically to detect errors as part of package building.

As the examples are written now, mostly all of them will fail with errors, since the resources don't actually exist.

@Alanwe
Copy link
Member Author

Alanwe commented Jun 12, 2017

Sure, already starting to do so. It used to work like that however it needs updating to reflect some of the changes.

@andrie
Copy link
Contributor

andrie commented Jun 12, 2017

Hmm. As the tutorial stands, for most of the examples you needed to have an existing Azure resource with the name you gave it. If any other user doesn't have an existing resource with that name, then the example will fail.

Alanwe added a commit that referenced this issue Jun 15, 2017
Error in azureResizeHDI. IsInteger assert.
andrie added a commit that referenced this issue Jun 15, 2017
* dev:
  Fixed errors in tutorial.Rmd #75 Error in azureResizeHDI. IsInteger assert.
  Fix documentation issues; add @family to roxygen
  Document cost functions in package documentation
  Added batch test
  Add Azure Batch functions to package documentation; fix some typos
  Update tutorial.R
  Replace calling with call_azure_sm function
  Renamed list batch accounts function
  Added List Batch Accounts function
  Added initial commit for Azure resource management for batch
@andrie andrie changed the title Errors in Tutorials Fix errors in vignettes Jun 16, 2017
@andrie andrie added this to the v0.2.6 milestone Jun 16, 2017
@andrie andrie assigned andrie and unassigned Alanwe Jun 16, 2017
andrie added a commit that referenced this issue Jun 16, 2017
andrie added a commit that referenced this issue Jun 16, 2017
* dev:
  Bump version to 0.2.6
  Small changes in Azure Batch functions
  Split message into multiple lines.
  Fix bug in argument naming
  More fixes to vignettes #76
  Document how to use blob store functions without authentication #76
  Fix errors and typos in vignettes #75
@andrie andrie closed this as completed Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants