-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karlie/web snippet #891
Merged
Merged
Karlie/web snippet #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
reviewed
Jan 22, 2022
hectorhdzg
reviewed
Jan 22, 2022
hectorhdzg
reviewed
Jan 22, 2022
hectorhdzg
reviewed
Jan 22, 2022
MSNev
reviewed
Jan 24, 2022
ramthi
requested changes
Jan 26, 2022
hectorhdzg
reviewed
Mar 15, 2022
hectorhdzg
reviewed
Mar 15, 2022
hectorhdzg
reviewed
Mar 15, 2022
hectorhdzg
reviewed
Mar 15, 2022
hectorhdzg
reviewed
Mar 15, 2022
hectorhdzg
reviewed
Mar 15, 2022
hectorhdzg
reviewed
Mar 15, 2022
hectorhdzg
reviewed
Mar 15, 2022
hectorhdzg
reviewed
Mar 15, 2022
hectorhdzg
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please merge with latest changes in develop branch
ramthi
approved these changes
Mar 30, 2022
Lets Ship it!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR
Current updates
Haven't been supported yet:
useCompression
is applied)Major updates1:
commit1: without npm package, use hard code snippet
commit2: use test npm package
Next: use Microsoft scope npm and update
package.json
andpackage-lock.json