Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karlie/web snippet #891

Merged
merged 19 commits into from
Mar 30, 2022
Merged

Karlie/web snippet #891

merged 19 commits into from
Mar 30, 2022

Conversation

Karlie-777
Copy link

@Karlie-777 Karlie-777 commented Jan 21, 2022

This is a draft PR

Current updates

  • support buffer
  • support https
  • support data sent in different chunks
  • large response body
  • support content-encoding (conditions applied)

Haven't been supported yet:

  1. partial compression (especially when Express useCompression is applied)
  2. use async compression/decompression in monkey patch
  3. npm package to import snippet (will be done when the issues mentioned above are addressed)

Major updates1:
commit1: without npm package, use hard code snippet
commit2: use test npm package
Next: use Microsoft scope npm and update package.json and package-lock.json

AutoCollection/WebSnippet.ts Outdated Show resolved Hide resolved
AutoCollection/WebSnippet.ts Show resolved Hide resolved
AutoCollection/WebSnippet.ts Outdated Show resolved Hide resolved
AutoCollection/WebSnippet.ts Show resolved Hide resolved
AutoCollection/WebSnippet.ts Show resolved Hide resolved
AutoCollection/WebSnippet.ts Outdated Show resolved Hide resolved
AutoCollection/WebSnippet.ts Outdated Show resolved Hide resolved
AutoCollection/WebSnippet.ts Outdated Show resolved Hide resolved
AutoCollection/WebSnippet.ts Outdated Show resolved Hide resolved
AutoCollection/WebSnippet.ts Outdated Show resolved Hide resolved
Library/JsonConfig.ts Outdated Show resolved Hide resolved
Library/JsonConfig.ts Outdated Show resolved Hide resolved
Library/Config.ts Outdated Show resolved Hide resolved
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge with latest changes in develop branch

@ramthi
Copy link
Member

ramthi commented Mar 30, 2022

Lets Ship it!!

@Karlie-777 Karlie-777 merged commit c4b5d32 into develop Mar 30, 2022
@hectorhdzg hectorhdzg deleted the karlie/webSnippet branch April 8, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants