Fix issue with live metrics initialization

microsoft · Sep 26, 2023 · c018ab8 · c018ab8
1 parent 86a575f
commit c018ab8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/Tests/applicationInsights.tests.ts b/Tests/applicationInsights.tests.ts
@@ -77,7 +77,10 @@ describe("ApplicationInsights", () => {
             WebSnippet.INSTANCE= undefined;
         });
 
-        afterEach(() => AppInsights.defaultClient = undefined);
+        afterEach(() => {
+            AppInsights.defaultClient = undefined;
+            AppInsights.liveMetricsClient = undefined;
+        });
 
         it("should warn if start is called before setup", () => {
             var warnStub = sandbox.stub(console, "warn");

diff --git a/applicationinsights.ts b/applicationinsights.ts
@@ -120,7 +120,7 @@ function _setDefaultConfig() {
             defaultClient.config.enableAutoDependencyCorrelation = true;
         }
         if (defaultClient.config.enableSendLiveMetrics == undefined) {
-            defaultClient.config.enableSendLiveMetrics = true;
+            defaultClient.config.enableSendLiveMetrics = false;
         }
         if (defaultClient.config.enableAutoCollectExtendedMetrics == undefined) {
             defaultClient.config.enableAutoCollectExtendedMetrics = true;
@@ -154,7 +154,14 @@ export function start() {
         _serverRequests.enable(defaultClient.config.enableAutoCollectRequests);
         _clientRequests.enable(defaultClient.config.enableAutoCollectDependencies);
         _webSnippet.enable(defaultClient.config.enableWebInstrumentation, defaultClient.config.webInstrumentationConnectionString);
-        if (liveMetricsClient && defaultClient.config.enableSendLiveMetrics) {
+        if (defaultClient.config.enableSendLiveMetrics) {
+            if (!liveMetricsClient) {
+                // No qps client exists. Create one and prepare it to be enabled at .start()
+                liveMetricsClient = new QuickPulseClient(defaultClient.config, defaultClient.context, defaultClient.getAuthorizationHandler);
+                _performanceLiveMetrics = new AutoCollectPerformance(liveMetricsClient as any, 1000, true);
+                liveMetricsClient.addCollector(_performanceLiveMetrics);
+                defaultClient.quickPulseClient = liveMetricsClient; // Need this so we can forward all manual tracks to live metrics via PerformanceMetricsTelemetryProcessor
+            }
             liveMetricsClient.enable(defaultClient.config.enableSendLiveMetrics);
         }
         _azureFunctions.enable(defaultClient.config.enableAutoCollectIncomingRequestAzureFunctions);
@@ -505,7 +512,6 @@ export function dispose() {
     }
     if (liveMetricsClient) {
         liveMetricsClient.enable(false);
-        defaultClient.config.enableSendLiveMetrics = false;
         liveMetricsClient = undefined;
     }
     if (_azureFunctions) {