Fix issue with Diagnosticlogger errors logging (#955)

microsoft · Apr 26, 2022 · 491aea2 · 491aea2
1 parent 831807d
commit 491aea2
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/Bootstrap/DiagnosticLogger.ts b/Bootstrap/DiagnosticLogger.ts
@@ -5,6 +5,7 @@ import * as DataModel from "./DataModel";
 import { FileWriter } from "./FileWriter";
 import { homedir } from "./Helpers/FileHelpers";
 import { APPLICATION_INSIGHTS_SDK_VERSION } from "../Declarations/Constants";
+import Util = require("../Library/Util");
 
 export class DiagnosticLogger {
     public static readonly DEFAULT_FILE_NAME: string = "application-insights-extension.log";
@@ -29,10 +30,7 @@ export class DiagnosticLogger {
         DiagnosticLogger.DefaultEnvelope.properties.ikey = instrumentationKey;
     }
 
-    logMessage(message: DataModel.DiagnosticLog | string, cb?: (err: Error) => void) {
-        if (typeof cb === "function" && this._writer instanceof FileWriter) {
-            this._writer.callback = cb;
-        }
+    logMessage(message: DataModel.DiagnosticLog | string) {
         if (typeof message === "string") {
             const diagnosticMessage: DataModel.DiagnosticLog = {
                 ...DiagnosticLogger.DefaultEnvelope,
@@ -50,9 +48,9 @@ export class DiagnosticLogger {
         }
     }
 
-    logError(message: DataModel.DiagnosticLog | string, cb?: (err: Error) => void) {
-        if (typeof cb === "function" && this._writer instanceof FileWriter) {
-            this._writer.callback = cb;
+    logError(message: DataModel.DiagnosticLog | string, err?: Error) {
+        if (err) {
+            message += ` ${Util.dumpObj(err)}`;
         }
         if (typeof message === "string") {
             const diagnosticMessage: DataModel.DiagnosticLog = {