Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable module metadata for all release artifacts #3836

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Disable module metadata for all release artifacts #3836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6387f38
Disable module metadata for all release artifacts
heyams Aug 12, 2024
ab041f9
It's better to be in ai.java-conventions
heyams Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions agent/agent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,6 @@ tasks {
named("generateLicenseReport").configure {
dependsOn(cleanLicenses)
}

// Because we reconfigure publishing to only include the shadow jar, the Gradle metadata is not correct.
// Since we are fully bundled and have no dependencies, Gradle metadata wouldn't provide any advantage over
// the POM anyways so in practice we shouldn't be losing anything.
withType<GenerateModuleMetadata>().configureEach {
enabled = false
}
}

// Don't publish non-shadowed jar (shadowJar is in shadowRuntimeElements)
Expand Down
5 changes: 0 additions & 5 deletions agent/runtime-attach/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,4 @@ tasks {
attributes("Automatic-Module-Name" to "com.microsoft.applicationinsights.attach")
}
}

// disabling the publication of Gradle Module Metadata
withType<GenerateModuleMetadata>().configureEach {
enabled = false
}
}
8 changes: 8 additions & 0 deletions buildSrc/src/main/kotlin/ai.java-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@ tasks {
isPreserveFileTimestamps = false
isReproducibleFileOrder = true
}

// disabling the publication of Gradle Module Metadata
// Because we reconfigure publishing to only include the shadow jar, the Gradle metadata is not correct.
// Since we are fully bundled and have no dependencies, Gradle metadata wouldn't provide any advantage over
// the POM anyways so in practice we shouldn't be losing anything.
withType<GenerateModuleMetadata>().configureEach {
enabled = false
}
}

normalization {
Expand Down
Loading