Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check connection string env var before loading from a file #3794

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Jul 23, 2024

Fix #3707

replaced #3759

regression from #3471

@heyams heyams changed the title Revert connection string config Check connection string env var before loading from a file Jul 23, 2024
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were going to revert the change you made in #3471?

@heyams
Copy link
Contributor Author

heyams commented Jul 23, 2024

I thought we were going to revert the change you made in #3471?

you cannot simply revert because we support loading from the file feature.

@heyams heyams merged commit 4e231e5 into main Jul 24, 2024
87 checks passed
@heyams heyams deleted the heya/revert-connection-string branch July 24, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APPLICATIONINSIGHTS_CONNECTION_STRING does not work in 3.5.x, works in 3.4.x
3 participants