[Main][Task]28736784: Update the Config Used for Type Docs with Test Web Config Endpoint #2403
Conversation
| @@ -31,7 +31,9 @@ let scriptContent = fs.readFileSync(scriptFilePath, 'utf8'); | |||
| // Replace the placeholder string with the actual connection string | |||
| const connectionString = 'InstrumentationKey=1ae9e7ce-18f1-4e14-8fc0-acbf0ed28895;IngestionEndpoint=https://eastus-8.in.applicationinsights.azure.com/;LiveEndpoint=https://eastus.livediagnostics.monitor.azure.com/'; | |||
| let iKeyForCfgSync = "1ae9e7ce-18f1-4e14-8fc0-acbf0ed28895"; | |||
| scriptContent = scriptContent.replace(`connectionString: "YOUR_CONNECTION_STRING"`, `instrumentationKey: "${iKeyForCfgSync}",\n \t\textensionConfig: {\n\t\t\t"AppInsightsCfgSyncPlugin": {\n\t\t\t\tcfgUrl:"https://js.monitor.azure.com/beta/ai.config.1.cfg.json"\n\t\t\t}\n\t\t}`); | |||
| //let cfgUrl = "https://js.monitor.azure.com/beta/ai.config.1.cfg.json"; | |||
| let cfgUrl = "https://tst2cdnstore.blob.core.windows.net/cdn/nevtest/ai.cfgSync.json"; | |||
There was a problem hiding this comment.
Lets not use this URL as it's pointing directly to the test storage account which won't do everything needed for every browser and won't really handle the scale correctly.
Let use the "test" folder of the standard js.monitor.azure.com (we will need to update the deployment pipeline for this -- or perhaps use the "nightly" folder and we just put in a "test" file (not called ai.cfgSync.json) perhaps ai.typedoc.cfgSunc.json) or our test CDN
There was a problem hiding this comment.
So current nightly is going to https://[js.monitor.azure.com/nightly/ai.3-nightly3.min.js](https://js.monitor.azure.com/nightly/ai.3-nightly3.min.js)
But I noticed that we are not currently publishing the cfgSync at all nightly, so we will need to add that to the pipeline and then also "add" the ability for it to publish a "test" version (so we don't accidently publish over the real one in the standard pipeline... (Which I was I suggested another file) so maybe either
ai_typedoc.cfgSunc.jsonorai_test.cfgSync.json(as the dot after theaiwill cause issues parsing the name for promoting the version
gruntfile.js
Outdated
|
|
||
| testConfig: { | ||
| files: [ | ||
| { src: "./tools/config/config.json", dest: `./tools/config/browser/es5/ai_test.config${configVer}.cfg.json` }, |
There was a problem hiding this comment.
Do we "really" want to copy the single "default" one to the test, I was suggesting that we actually have 2 checked in, so this would copy the test one as the test
There was a problem hiding this comment.
Thanks Nev for pointing it out! I just found it as well and it should be "test-config", I already updated the PR!
| @@ -32,7 +32,7 @@ let scriptContent = fs.readFileSync(scriptFilePath, 'utf8'); | |||
| const connectionString = 'InstrumentationKey=1ae9e7ce-18f1-4e14-8fc0-acbf0ed28895;IngestionEndpoint=https://eastus-8.in.applicationinsights.azure.com/;LiveEndpoint=https://eastus.livediagnostics.monitor.azure.com/'; | |||
| let iKeyForCfgSync = "1ae9e7ce-18f1-4e14-8fc0-acbf0ed28895"; | |||
| //let cfgUrl = "https://js.monitor.azure.com/beta/ai.config.1.cfg.json"; | |||
| let cfgUrl = "https://js.monitor.azure.com/nightly/ai_test.config.1.cfg.json"; | |||
| let cfgUrl = "https://js.monitor.azure.com/nightly/ai_test.config.1.0-nightly3.cfg.json"; | |||
There was a problem hiding this comment.
Right now it's probably 1.0-nightly3 (because the version gets flattened from 1.0.0 to 1.0 and 1) but it probably should be listed as 1-nightly3
There was a problem hiding this comment.
just changed it! Thanks Nev!
No description provided.