name difference fix (#2445)

microsoft · Nov 11, 2024 · 3dc9e3c · 3dc9e3c
1 parent f8b6d94
commit 3dc9e3c
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 15 deletions.
diff --git a/tools/applicationinsights-web-snippet/src/1dsSupport.ts b/tools/applicationinsights-web-snippet/src/1dsSupport.ts
@@ -88,8 +88,8 @@ let capturePage = "capturePage";
 export const oneDsMethods = [
     track + "Event",
     track + "Exception",
-    trackPage + "View",
-    trackPage + "ViewPerformance",
+    track + "PageView",
+    track + "PageViewPerformance",
     "addTelemetryInitializer",
     track,
     trackPage + "Action",

diff --git a/tools/applicationinsights-web-snippet/src/aiSupport.ts b/tools/applicationinsights-web-snippet/src/aiSupport.ts
@@ -42,8 +42,8 @@ let trackEvent = "TrackEvent";
 export const aiMethod = [
     track + "Event",
     track + "Exception",
-    trackPage + "View",
-    trackPage + "ViewPerformance",
+    track + "PageView",
+    track + "PageViewPerformance",
     "addTelemetryInitializer",
     track + "Trace",
     track + "DependencyData",

diff --git a/tools/applicationinsights-web-snippet/src/snippet.ts b/tools/applicationinsights-web-snippet/src/snippet.ts
@@ -36,29 +36,33 @@ declare var cfg:ISnippetConfig;
     let sdkInstanceName:string;
     let aiName:string;
 
+
+    if (isOneDS){
+        sdkInstanceName = "onedsSDK";
+        aiName = cfg.name || "oneDSWeb";  // provide non default instance name through snipConfig name value
+    } else {
+        sdkInstanceName = "appInsightsSDK";
+        aiName = cfg.name || "appInsights";
+    }
+
     if (cfg.name || win[sdkInstanceName]) {
         // Only set if supplied or another name is defined to avoid polluting the global namespace
         win[sdkInstanceName] = aiName;
     }
+
     let aiSdk = win[aiName] || (function (aiConfig: IConfiguration & IConfig , aiExtensions?: any) {
         let targetSrc : string = (aiConfig as any)["url"] || cfg.src;
-        if (isOneDS){
-            sdkInstanceName = "onedsSDK";
-            aiName = cfg.name || "oneDSWeb";  // provide non default instance name through snipConfig name value
-        } else {
-            sdkInstanceName = "appInsightsSDK";
-            aiName = cfg.name || "appInsights";
-        }
+
 
         let loadFailed = false;
         let handled = false;
-        let appInsights: (Snippet & {cookie?:any, core?:any, extensions?:any, initialize?: boolean, isInitialized?: () => boolean;}) = null;
-        appInsights= {
+        let appInsights: (Snippet & {cookie?:any, core?:any, extensions?:any, initialize?: boolean, isInitialized?: () => boolean;}) = {
+            initialize: true,   // initialize sdk on download
             queue: [],
             sv: "8",       // Track the actual snippet version for reporting.
             config: aiConfig,
-            extensions: aiExtensions,
-            initialize: true   // initialize sdk on download
+            version: 2.0,
+            extensions: aiExtensions
         };
 
         if (isOneDS && !aiConfig["webAnalyticsConfiguration"]){