Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popup background color for high contrast mode #7497

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

anna-dingler
Copy link
Contributor

@anna-dingler anna-dingler commented Jun 8, 2022

Related Issue

Fixes #7494

Description

ActiveBorder should only be the background color when in high contrast mode.

How Verified

Manually with and without high contrast mode.

Without:
image

High contrast Aquatic theme:
image

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jun 8, 2022

Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Designer] ActiveBorder not the appropriate color to use for dialog background color
2 participants