Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a caption to the table present in the 'help' dialog #7149

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Add a caption to the table present in the 'help' dialog #7149

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2706e59
move keyboard shortcut text to caption
PankajBhojwani Mar 16, 2022
9229703
Merge branch 'main' into dev/pabhoj/table_caption
PankajBhojwani Mar 16, 2022
7408694
use innerText instead
PankajBhojwani Mar 16, 2022
89ca948
Merge branch 'dev/pabhoj/table_caption' of https://github.com/microso…
PankajBhojwani Mar 16, 2022
39fd34f
Merge branch 'main' into dev/pabhoj/table_caption
PankajBhojwani Mar 17, 2022
1e923a1
Update source/nodejs/adaptivecards-designer/src/help-dialog.ts
licanhua Mar 17, 2022
1c6d31e
Merge branch 'main' into dev/pabhoj/table_caption
PankajBhojwani Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions source/nodejs/adaptivecards-designer/src/help-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,14 @@ export class HelpDialog extends Dialog {
keyboardHeading.innerText = "Keyboard Shortcuts";
this._renderedElement.appendChild(keyboardHeading);

let keyboardText = document.createElement("div");
keyboardText.innerText = "These keyboard shortcuts only work when the keyboard focus is within either the card payload or sample data editors";
this._renderedElement.appendChild(keyboardText);
this._renderedElement.appendChild(document.createElement("br"));

let shortcutTable = document.createElement("table");

let tableCaption = shortcutTable.createCaption();
tableCaption.style.textAlign = "left";
tableCaption.innerText = "These keyboard shortcuts only work when the keyboard focus is within either the card payload or sample data editors";

shortcutTable.appendChild(document.createElement("br"));

shortcutTable.appendChild(this._getShortcutRow("Shortcut", "Description", true));
shortcutTable.appendChild(this._getShortcutRow("Alt-F1", "Show help dialog for editor"));
shortcutTable.appendChild(this._getShortcutRow("Ctrl-M", "Toggle behavior of TAB key. By default, pressing TAB will insert a TAB character. When toggled, pressing TAB will navigate to the next focusable item."));
Expand Down