Designer fixes #4094
Merged
Designer fixes #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
paulcam206
approved these changes
Jun 4, 2020
|
/azp run |
|
No pipelines are associated with this pull request. |
shalinijoshi19
added
AdaptiveCards v20.06
Area-Designer
Platform-JavaScript
|
🎉 Handy links: |
ghost
mentioned this pull request
This was referenced Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4092
Fixes #4093
Fixes MicrosoftDocs/AdaptiveCards#285
Fixes #4106
Fixes #4042 (comment)
Description
subtleproperty instead of theisSubtlepropertyContainer.styleproperty if it is invalid (instead of forcing it to beundefined.) This fixes the issue of not being able to bindContainer.style, and also fixes the same issue forChoiceSetInput.style,Action.styleandCardElement.heightHttpAction.methodproperty was mistakenly mapped to body, making it impossible to set the body property, which in turn caused an exception in the designer$indexto 0 even for non-array expansion.How Verified
Varified manually in adaptivecards-designer-app
Microsoft Reviewers: Open in CodeFlow